Ticket #61 (defect)
Opened 1 year ago
Last modified 1 year ago
method show_captcha() not MVC compliant
Status: closed (fixed)
| Reported by: | danfreak | Assigned to: | grahack |
|---|---|---|---|
| Priority: | minor | Milestone: | |
| Component: | software design & optimization | Version: | 1.0.4 |
| Keywords: | Cc: | ||
I suggest to move the method show_captcha() from the main FreakAuth_light library to the helper because it is not compliant with an MVC structure.
Change History
05/28/07 05:08:35: Modified by danfreak
- status changed from new to closed.
- resolution set to fixed.
05/28/07 15:07:55: Modified by grahack
- status changed from closed to reopened.
- resolution deleted.
Don't you think that it should go in FAL_front.php ?
this is where the forms are generated, so I think that it should be the place
05/29/07 10:34:35: Modified by danfreak
- status changed from reopened to closed.
- resolution set to fixed.
Well in my opinion no.
I explain you what I mean for helpers, and maybe you will get my point. Helpers include small functions to help a coder out (namely code reusability) in controllers, libraries or views.
In our particular case the function show_captcha():
- has nothing to do with the other functions of neither the Freakauth_light library neither the FAL_front library
- it just returns some HTML
Therefore it's just used in views. It's more handy to leave it alone among the helpers functions, easier to customise the HTML in it without hacking the main library.
I hope this makes sense. In libraries we should try to put just essential code, and not HTML etc. as much as possible.
05/31/07 11:57:43: Modified by grahack
[281] puts the html code in a view file
06/27/07 08:23:29: Modified by
- milestone deleted.
Milestone 1.0.5 deleted
in [265]